int auth_set_password(const char *username, const char *password) {
char filename[FILENAME_MAX];
- unsigned char pwhash[SCRYPT_OUTPUT_SIZE];
+ uint8_t pwhash[SCRYPT_OUTPUT_SIZE];
uint8_t salt[SCRYPT_SALT_SIZE];
int fd, n, r;
char filename[FILENAME_MAX];
int fd;
char str[4];
- int len;
+ int len = 0;
snprintf(filename, FILENAME_MAX, "%s/%s/password_version", blergconf.data_path, username);
if (access(filename, F_OK) != 0) {
}
fd = open(filename, O_RDONLY);
+ if (fd == -1)
+ return -1;
len = read(fd, str, 4);
close(fd);
+
+ if (len < -1) {
+ perror("auth_get_password_version");
+ return -1;
+ }
+
str[len] = 0;
+
/* strtol returns zero if there isn't a number */
return strtol(str, NULL, 10);
}
int auth_get_password(const char *username, char *password) {
char filename[FILENAME_MAX];
int fd;
+ int read_size;
int len = 0;
if (!valid_name(username))
return 0;
- snprintf(filename, FILENAME_MAX, "%s/%s/password", blergconf.data_path, username);
- fd = open(filename, O_RDONLY);
- if (fd == -1)
- return 0;
switch(auth_get_password_version(username)) {
case 0:
- len = read(fd, password, MD5_DIGEST_SIZE);
+ read_size = MD5_DIGEST_SIZE;
break;
case 1:
- len = read(fd, password, SCRYPT_OUTPUT_SIZE);
+ read_size = SCRYPT_OUTPUT_SIZE;
break;
+ default:
+ return 0;
}
+
+ snprintf(filename, FILENAME_MAX, "%s/%s/password", blergconf.data_path, username);
+ fd = open(filename, O_RDONLY);
+ if (fd == -1)
+ return 0;
+ len = read(fd, password, read_size);
close(fd);
+ if (len < 0) {
+ perror("auth_get_password");
+ return 0;
+ } else if (len < read_size) {
+ fprintf(stderr, "Short read getting password\n");
+ return 0;
+ }
+
password[len] = 0;
return 1;
int auth_get_salt(const char *username, uint8_t *salt) {
char filename[FILENAME_MAX];
- int fd, len;
+ int fd;
+ int len = 0;
if (!valid_name(username))
return 0;
len = read(fd, salt, SCRYPT_SALT_SIZE);
close(fd);
+ if (len < 0) {
+ perror("auth_get_salt");
+ return 0;
+ } else if (len < SCRYPT_SALT_SIZE) {
+ fprintf(stderr, "Short read getting salt\n");
+ return 0;
+ }
+
return 1;
}
unsigned char givenpw[SCRYPT_OUTPUT_SIZE];
int r;
- if (auth_get_password(username, epw) == 0)
+ if (auth_get_password(username, (char *)epw) == 0)
return 0;
if (auth_get_salt(username, esalt) == 0)
return 0;
- r = crypto_scrypt(password, strlen(password), esalt, SCRYPT_SALT_SIZE, SCRYPT_N, SCRYPT_r, SCRYPT_p, givenpw, SCRYPT_OUTPUT_SIZE);
+ r = crypto_scrypt((const uint8_t *)password, strlen(password), esalt, SCRYPT_SALT_SIZE, SCRYPT_N, SCRYPT_r, SCRYPT_p, givenpw, SCRYPT_OUTPUT_SIZE);
if (r != 0) {
fprintf(stderr, "Failure in scrypt for %s\n", username);
return 0;
case 1:
return auth_check_password_v1(username, password);
}
+ fprintf(stderr, "auth_check_password fell through. Bad password version?\n");
+ return 0;
}
void hexify(char *dst, char *src, int len) {
}
char *create_random_token() {
- unsigned char buf[TOKEN_SIZE];
+ char buf[TOKEN_SIZE];
char *token;
int rand_fd;