X-Git-Url: http://git.bytex64.net/?a=blobdiff_plain;f=common%2Fauth.c;h=ef548ec8a312e23c9a7ec212c821b97dac29adc8;hb=abeaeafe6860bef22ab8469261d3198efc8358c1;hp=a4a40cd001f34f0a0b103d9732fc402a79ba575d;hpb=65363bdbdec43b2efd906d8fa848fc4d69c529d2;p=blerg.git

diff --git a/common/auth.c b/common/auth.c
index a4a40cd..ef548ec 100644
--- a/common/auth.c
+++ b/common/auth.c
@@ -18,7 +18,7 @@
 
 int auth_set_password(const char *username, const char *password) {
 	char filename[FILENAME_MAX];
-	unsigned char pwhash[SCRYPT_OUTPUT_SIZE];
+	uint8_t pwhash[SCRYPT_OUTPUT_SIZE];
 	uint8_t salt[SCRYPT_SALT_SIZE];
 	int fd, n, r;
 
@@ -69,7 +69,7 @@ int auth_get_password_version(const char *username) {
 	char filename[FILENAME_MAX];
 	int fd;
 	char str[4];
-	int len;
+	int len = 0;
 
 	snprintf(filename, FILENAME_MAX, "%s/%s/password_version", blergconf.data_path, username);
 	if (access(filename, F_OK) != 0) {
@@ -77,9 +77,18 @@ int auth_get_password_version(const char *username) {
 	}
 
 	fd = open(filename, O_RDONLY);
+	if (fd == -1)
+		return -1;
 	len = read(fd, str, 4);
 	close(fd);
+
+	if (len < -1) {
+		perror("auth_get_password_version");
+		return -1;
+	}
+
 	str[len] = 0;
+
 	/* strtol returns zero if there isn't a number */
 	return strtol(str, NULL, 10);
 }
@@ -87,25 +96,38 @@ int auth_get_password_version(const char *username) {
 int auth_get_password(const char *username, char *password) {
 	char filename[FILENAME_MAX];
 	int fd;
+	int read_size;
 	int len = 0;
 
 	if (!valid_name(username))
 		return 0;
 
-	snprintf(filename, FILENAME_MAX, "%s/%s/password", blergconf.data_path, username);
-	fd = open(filename, O_RDONLY);
-	if (fd == -1)
-		return 0;
 	switch(auth_get_password_version(username)) {
 	case 0:
-		len = read(fd, password, MD5_DIGEST_SIZE);
+		read_size = MD5_DIGEST_SIZE;
 		break;
 	case 1:
-		len = read(fd, password, SCRYPT_OUTPUT_SIZE);
+		read_size = SCRYPT_OUTPUT_SIZE;
 		break;
+	default:
+		return 0;
 	}
+
+	snprintf(filename, FILENAME_MAX, "%s/%s/password", blergconf.data_path, username);
+	fd = open(filename, O_RDONLY);
+	if (fd == -1)
+		return 0;
+	len = read(fd, password, read_size);
 	close(fd);
 
+	if (len < 0) {
+		perror("auth_get_password");
+		return 0;
+	} else if (len < read_size) {
+		fprintf(stderr, "Short read getting password\n");
+		return 0;
+	}
+
 	password[len] = 0;
 
 	return 1;
@@ -113,7 +135,8 @@ int auth_get_password(const char *username, char *password) {
 
 int auth_get_salt(const char *username, uint8_t *salt) {
 	char filename[FILENAME_MAX];
-	int fd, len;
+	int fd;
+	int len = 0;
 
 	if (!valid_name(username))
 		return 0;
@@ -125,6 +148,14 @@ int auth_get_salt(const char *username, uint8_t *salt) {
 	len = read(fd, salt, SCRYPT_SALT_SIZE);
 	close(fd);
 
+	if (len < 0) {
+		perror("auth_get_salt");
+		return 0;
+	} else if (len < SCRYPT_SALT_SIZE) {
+		fprintf(stderr, "Short read getting salt\n");
+		return 0;
+	}
+
 	return 1;
 }
 
@@ -153,13 +184,13 @@ int auth_check_password_v1(const char *username, const char *password) {
 	unsigned char givenpw[SCRYPT_OUTPUT_SIZE];
 	int r;
 
-	if (auth_get_password(username, epw) == 0)
+	if (auth_get_password(username, (char *)epw) == 0)
 		return 0;
 
 	if (auth_get_salt(username, esalt) == 0)
 		return 0;
 
-	r = crypto_scrypt(password, strlen(password), esalt, SCRYPT_SALT_SIZE, SCRYPT_N, SCRYPT_r, SCRYPT_p, givenpw, SCRYPT_OUTPUT_SIZE);
+	r = crypto_scrypt((const uint8_t *)password, strlen(password), esalt, SCRYPT_SALT_SIZE, SCRYPT_N, SCRYPT_r, SCRYPT_p, givenpw, SCRYPT_OUTPUT_SIZE);
 	if (r != 0) {
 		fprintf(stderr, "Failure in scrypt for %s\n", username);
 		return 0;
@@ -187,6 +218,8 @@ int auth_check_password(const char *username, const char *password) {
 	case 1:
 		return auth_check_password_v1(username, password);
 	}
+	fprintf(stderr, "auth_check_password fell through. Bad password version?\n");
+	return 0;
 }
 
 void hexify(char *dst, char *src, int len) {
@@ -200,7 +233,7 @@ void hexify(char *dst, char *src, int len) {
 }
 
 char *create_random_token() {
-	unsigned char buf[TOKEN_SIZE];
+	char buf[TOKEN_SIZE];
 	char *token;
 	int rand_fd;